Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean field for content_default_http_proxy in HTTProxy entity #1254

Merged

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Nov 19, 2024

Description of changes

Change introduced in Katello/katello#11183 and Katello/katello#11266

@Gauravtalreja1 Gauravtalreja1 added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 19, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Nov 19, 2024
nailgun/entities.py Outdated Show resolved Hide resolved
Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Jan 10, 2025
@dosas
Copy link
Collaborator

dosas commented Jan 10, 2025

@vsedmik How do we proceed here?

@dosas dosas removed the Stale Stale issue or Pull Request label Jan 10, 2025
@Gauravtalreja1 Gauravtalreja1 force-pushed the default-http-proxy-locator branch from a837eca to ae46f6b Compare January 10, 2025 21:25
@Gauravtalreja1 Gauravtalreja1 changed the title Add boolean field for default_content_http_proxy in HTTProxy entity Add boolean field for content_default_http_proxy in HTTProxy entity Jan 10, 2025
@vsedmik
Copy link
Contributor

vsedmik commented Jan 14, 2025

@dosas looks like Katello/katello#11266 was merged yesterday, which should make this PR in line with product. But I haven't tried it locally yet.
@Gauravtalreja1, would you provide the functional demonstration against packit w/ #11266 instance (or against stream snap once it gets in)?

@Gauravtalreja1 Gauravtalreja1 force-pushed the default-http-proxy-locator branch from ae46f6b to 0f5aa21 Compare February 5, 2025 19:07
@Gauravtalreja1 Gauravtalreja1 force-pushed the default-http-proxy-locator branch 2 times, most recently from 1a850fb to f14ca44 Compare February 13, 2025 11:40
nailgun/entities.py Show resolved Hide resolved
@Gauravtalreja1 Gauravtalreja1 force-pushed the default-http-proxy-locator branch from f14ca44 to d18e983 Compare February 14, 2025 09:49
@shubhamsg199 shubhamsg199 merged commit 7ef23c0 into SatelliteQE:master Feb 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants